[PATCH] USB: pl2303: switch to generic write implementation

Submitted by Oliver Neukum on Wed, 03/03/2010 - 08:10

Am Mittwoch, 3. März 2010 16:01:33 schrieb Johan Hovold:
> @@ -941,10 +665,8 @@ static void pl2303_release(struct usb_serial *serial)
>
> for (i = 0; i < serial->num_ports; ++i) {
> priv = usb_get_serial_port_data(serial->port[i]);
> - if (priv) {
> - pl2303_buf_free(priv->buf);
> + if (priv)
> kfree(priv);
> - }
> }
> }

No need to test for NULL.

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

‹ [RFC] x86,perf: Implement minimal P4 PMU driver v14 Will's kernel compilation error ›

[PATCH v2] USB: pl2303: switch to generic write implementation

Submitted by Johan Hovold on Wed, 03/17/2010 - 02:37.

On Mon, Mar 15, 2010 at 04:20:05PM -0700, Greg KH wrote:
> On Thu, Mar 04, 2010 at 12:12:52PM +0100, Johan Hovold wrote:
> > Replace custom fifo-based write implementation with the generic
> > kfifo-based one.
>
> What kernel is this patch against? For some reason it doesn't apply to
> my tree right now :(

It's against 2.6.33 (the bug report in question was against 2.6.32.9 so
I figured I'd rebase it against stable at least).

> Care to respin it?

I'll submit it along with some other patches shortly.

Thanks,
Johan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/